fix: printing PDF via webContents.print()#47377
Merged
Conversation
deepak1556
approved these changes
Jun 5, 2025
dsanders11
approved these changes
Jun 5, 2025
Member
dsanders11
left a comment
There was a problem hiding this comment.
I see this is the same pattern used in upstream, but what a footgun. 😅
jkleinsc
approved these changes
Jun 6, 2025
|
Release Notes Persisted
|
This was referenced Jun 6, 2025
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47398 |
Contributor
|
I have automatically backported this PR to "35-x-y", please check out #47399 |
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #47400 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: printing PDF via webContents.print()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #47272
Partially fixes an issue with printing a PDF via
webContents.print()where the callback would not be called and the print dialog sometimes not show. This was happening because we were not correctly using thePrintViewManagercreated for the PDF View Plugin'swebContents.Checklist
npm testpassesRelease Notes
Notes: Partially fixes an issue with printing a PDF via
webContents.print()where the callback would not be called.