Skip to content

feat: add support for --no-experimental-global-navigator#47370

Merged
deepak1556 merged 1 commit intomainfrom
robo/support_disabling_global_navigator
Jun 9, 2025
Merged

feat: add support for --no-experimental-global-navigator#47370
deepak1556 merged 1 commit intomainfrom
robo/support_disabling_global_navigator

Conversation

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 4, 2025 •
edited
Loading

Description of Change

With Node.js v21 starting to support global navigator object, applications that load 3-rd party plugins need to provide a migration timeline for these plugins that relied on the presence of navigator object to detect web environments which would not be the case anymore.

nodejs/node@309c71a

Release Notes

Notes: add support for --no-experimental-global-navigator flag

@deepak1556 deepak1556 added semver/minor backwards-compatible functionality target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Jun 4, 2025
@deepak1556 deepak1556 mentioned this pull request Jun 4, 2025
Closed
3 tasks
samuelmaddock
samuelmaddock approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

erickzhao
erickzhao approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

itsananderson
itsananderson approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@samuelmaddock samuelmaddock added the api-review/skip-delay ⏰ Skip the mandatory 7 day waiting period for new APIs label Jun 5, 2025
@deepak1556 deepak1556 merged commit c964296 into main Jun 9, 2025
73 of 74 checks passed
@deepak1556 deepak1556 deleted the robo/support_disabling_global_navigator branch June 9, 2025 05:57
@release-clerk
Copy link

release-clerk bot commented Jun 9, 2025

Release Notes Persisted

add support for --no-experimental-global-navigator flag

This was referenced Jun 9, 2025
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 9, 2025

I have automatically backported this PR to "35-x-y", please check out #47416

@trop trop bot added in-flight/35-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Jun 9, 2025
@trop
Copy link
Contributor

trop bot commented Jun 9, 2025

I have automatically backported this PR to "36-x-y", please check out #47417

@trop
Copy link
Contributor

trop bot commented Jun 9, 2025

I have automatically backported this PR to "37-x-y", please check out #47418

@trop trop bot added in-flight/36-x-y in-flight/37-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Jun 9, 2025
@trop trop bot removed the in-flight/37-x-y label Jun 23, 2025
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. and removed in-flight/35-x-y in-flight/36-x-y labels Jun 23, 2025
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@deepak1556 @kigh-ota
feat: add support for --no-experimental-global-navigator (electron#47370
701c5b7 
)

chore: add support for --no-experimental-global-navigator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@codebytere codebytere codebytere approved these changes

+2 more reviewers

@itsananderson itsananderson itsananderson approved these changes

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-review/requested 🗳 api-review/skip-delay ⏰ Skip the mandatory 7 day waiting period for new APIs merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. new-pr 🌱 PR opened recently semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deepak1556 @itsananderson @jkleinsc @samuelmaddock @codebytere @erickzhao