Skip to content

feat: context bridge support VideoFrame#47316

Merged
jkleinsc merged 2 commits intoelectron:mainfrom
reitowo:main-video-frame-bridge
Aug 7, 2025
Merged

feat: context bridge support VideoFrame#47316
jkleinsc merged 2 commits intoelectron:mainfrom
reitowo:main-video-frame-bridge

Conversation

@reitowo
Copy link
Copy Markdown
Member

@reitowo reitowo commented May 30, 2025

Description of Change

Add VideoFrame support for contextBridge. Split from #46811

Release Notes

Notes: none

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 30, 2025
@reitowo reitowo mentioned this pull request May 30, 2025
Closed
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 6, 2025
@velentZ
Copy link
Copy Markdown

velentZ commented Jun 17, 2025 •
edited
Loading

I also have a feature request about VideoFrame which has been supported called copy-video-frame when right click the context menu on a video player in chrome. However, I don`t know how to start.
Please give me a guidence, thanks

@josefhernandez
Copy link
Copy Markdown

josefhernandez commented Jun 26, 2025

How efficient is video frame serialization? I previously experimented with transmitting the ArrayBuffer between the front-end and back-end, but the performance was very poor.

@reitowo reitowo force-pushed the main-video-frame-bridge branch from 9882369 to 79faf4a Compare July 6, 2025 16:21
@reitowo reitowo marked this pull request as ready for review July 6, 2025 16:21
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jul 6, 2025
@reitowo reitowo force-pushed the main-video-frame-bridge branch from 79faf4a to 5467352 Compare July 6, 2025 17:53
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Jul 9, 2025

It has nothing to do with serialization

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jul 13, 2025
@reitowo reitowo force-pushed the main-video-frame-bridge branch from 5467352 to 10daa77 Compare July 14, 2025 14:29
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Jul 21, 2025

@codebytere @MarshallOfSound @VerteDinde Hi guys! Sorry for ping, but this and #47317 are ready for review! Could you spare some time review these two parts?

@erickzhao erickzhao added the semver/minor backwards-compatible functionality label Jul 24, 2025
erickzhao
erickzhao approved these changes Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

samuelmaddock
samuelmaddock reviewed Jul 31, 2025
View reviewed changes
Comment thread shell/renderer/api/electron_api_context_bridge.cc
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Jul 31, 2025

Ah 💩, here we go again.

@reitowo reitowo force-pushed the main-video-frame-bridge branch from b4e8d6a to c181aab Compare July 31, 2025 19:29
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Aug 5, 2025

@erickzhao Hey Erick, could you rerun flaky checks or just directly merge this? Thank you!

jkleinsc
jkleinsc reviewed Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

itsananderson
itsananderson approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit 095e622 into electron:main Aug 7, 2025
149 of 152 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Aug 7, 2025

No Release Notes

kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@reitowo @kigh-ota
feat: context bridge support VideoFrame (electron#47316)
2cf0cab 
* feat: context bridge support VideoFrame

* docs: add VideoFrame to docs
@huntercaron
Copy link
Copy Markdown

huntercaron commented Oct 26, 2025 •
edited
Loading

Hi! Do you know if this is included in any published versions yet? I am trying in v39.0.0-beta.5 but am having some troubles

Or do you have an example of how it can be used?

Edit: I just needed to dig into electron releases a bit more. The shared texture end-to-end flow works in electron@40.0.0-alpha.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelmaddock samuelmaddock samuelmaddock left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

+2 more reviewers

@itsananderson itsananderson itsananderson approved these changes

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-review/approved ✅ no-backport semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@reitowo @velentZ @josefhernandez @huntercaron @itsananderson @jkleinsc @samuelmaddock @erickzhao