feat: enable secondary label for macOS menu#46887
Merged
Conversation
deepak1556
reviewed
May 2, 2025
Co-authored-by: Robo <hop2deep@gmail.com>
Member
|
Should document in https://github.com/electron/electron/blob/main/docs/api/menu-item.md#new-menuitemoptions that sublabel is only supported on macOS >= 14.4 |
deepak1556
approved these changes
May 8, 2025
jkleinsc
approved these changes
May 9, 2025
|
Release Notes Persisted
|
This was referenced May 9, 2025
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #47040 |
Contributor
|
I have automatically backported this PR to "35-x-y", please check out #47041 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47042 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* feat: enable secondary label for macOS menu * Update shell/browser/ui/cocoa/electron_menu_controller.mm Co-authored-by: Robo <hop2deep@gmail.com> * fix for lint * update docs for sublabel --------- Co-authored-by: Robo <hop2deep@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34621
Adds sublabel functionality for macOS >= 14.4.
Tests and docs updates to come
Checklist
npm testpassesRelease Notes
Notes: added sublabel functionality for menus on macOS >= 14.4
@deepak1556 @VerteDinde