docs: add missing deprecations to breaking-changes.md#43217
Merged
VerteDinde merged 3 commits intoelectron:mainfrom Aug 6, 2024
piotrpdev:fix/missing-breaking-changes
Merged
docs: add missing deprecations to breaking-changes.md#43217VerteDinde merged 3 commits intoelectron:mainfrom piotrpdev:fix/missing-breaking-changes
breaking-changes.md#43217VerteDinde merged 3 commits intoelectron:mainfrom
piotrpdev:fix/missing-breaking-changes
Conversation
Reference: #35658
ckerr
approved these changes
Aug 6, 2024
dsanders11
approved these changes
Aug 6, 2024
|
No Release Notes |
Contributor
|
I have automatically backported this PR to "32-x-y", please check out #43228 |
VerteDinde
pushed a commit
that referenced
this pull request
Aug 19, 2024
* feat(api-history): api history schema Reference: https://github.com/electron/rfcs/blob/f36e0a8483e1ea844710890a8a7a1bd58ecbac05/text/0004-api-history-schema.md * feat(api-history): add `lint:api-history` to `package.json` * docs(api-history): add api history to `styleguide.md` * docs(api-history): `win.flashFrame(flag)` * docs(api-history): `new WebContentsView([options])` * docs(api-history): non-navigation APIs on `WebContents` * docs(api-history): `nativeImage.toDataURL` * docs(api-history): `window.flashFrame(bool)` * docs(api-history): `browser-view.md` * docs(api-history): `ipcRenderer` * docs(api-history): `protocol.*Protocol` * revert: `new WebContentsView([options])` This reverts commit 0a11efc. * Apply suggestions from code review Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * fix(api-history): remove incorrect `pr-url` Reference: https://github.com/electron/electron/pull/42982/files#r1692532877 * docs(api-history): schema word choice Co-authored-by: Erick Zhao <erick@hotmail.ca> Reference: electron/website@0b1b6a7 * docs(api-history): nicer format example in `styleguide.md` Reference: #42982 (comment) * docs(api-history): Always use double quotes for descriptions * docs(api-history): `styleguide.md` improvements * docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md` * docs(api-history): `styleguide.md` placement * docs(api-history): add migration guide * docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md` Reference: https://github.com/electron/electron/pull/42982/files/7b03c0703d7819add6afd022ec97a55b7a2aa268#r1703444772 * docs(api-history): move migration guide Reference: #42982 (comment) * docs(api-history): update `breaking-changer-header` Reference: #43217 * docs(api-history): deprecate `browser-view.md` --------- Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added some missing deprecations to
breaking-changes.md.See commit descriptions for links to relevant PRs.
Note
If 7453729 is merged, then modify/revert
997d1a4(#42982)@dsanders11 @erickzhao @VerteDinde
Checklist
npm testpassesRelease Notes
Notes: none