Skip to content

docs: add missing deprecations to breaking-changes.md#43217

Merged
VerteDinde merged 3 commits intoelectron:mainfrom
piotrpdev:fix/missing-breaking-changes
Aug 6, 2024
Merged

docs: add missing deprecations to breaking-changes.md#43217
VerteDinde merged 3 commits intoelectron:mainfrom
piotrpdev:fix/missing-breaking-changes

Conversation

@piotrpdev
Copy link
Contributor

Description of Change

Added some missing deprecations to breaking-changes.md.

See commit descriptions for links to relevant PRs.

Note

If 7453729 is merged, then modify/revert 997d1a4 (#42982)

@dsanders11 @erickzhao @VerteDinde

Checklist

Release Notes

Notes: none

@piotrpdev piotrpdev requested a review from a team as a code owner August 5, 2024 15:04
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Aug 5, 2024
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piotrpdev!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 6, 2024
@dsanders11 dsanders11 added the target/32-x-y PR should also be added to the "32-x-y" branch. label Aug 6, 2024
@VerteDinde VerteDinde merged commit f42331f into electron:main Aug 6, 2024
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 6, 2024

I have automatically backported this PR to "32-x-y", please check out #43228

@trop trop bot added in-flight/32-x-y merged/32-x-y PR was merged to the "32-x-y" branch. and removed target/32-x-y PR should also be added to the "32-x-y" branch. in-flight/32-x-y labels Aug 6, 2024
VerteDinde pushed a commit that referenced this pull request Aug 19, 2024
* feat(api-history): api history schema

Reference: https://github.com/electron/rfcs/blob/f36e0a8483e1ea844710890a8a7a1bd58ecbac05/text/0004-api-history-schema.md

* feat(api-history): add `lint:api-history` to `package.json`

* docs(api-history): add api history to `styleguide.md`

* docs(api-history): `win.flashFrame(flag)`

* docs(api-history): `new WebContentsView([options])`

* docs(api-history): non-navigation APIs on `WebContents`

* docs(api-history): `nativeImage.toDataURL`

* docs(api-history): `window.flashFrame(bool)`

* docs(api-history): `browser-view.md`

* docs(api-history): `ipcRenderer`

* docs(api-history): `protocol.*Protocol`

* revert: `new WebContentsView([options])`

This reverts commit 0a11efc.

* Apply suggestions from code review

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* fix(api-history): remove incorrect `pr-url`

Reference: https://github.com/electron/electron/pull/42982/files#r1692532877

* docs(api-history): schema word choice

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Reference: electron/website@0b1b6a7

* docs(api-history): nicer format example in `styleguide.md`

Reference: #42982 (comment)

* docs(api-history): Always use double quotes for descriptions

* docs(api-history): `styleguide.md` improvements

* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`

* docs(api-history): `styleguide.md` placement

* docs(api-history): add migration guide

* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`

Reference: https://github.com/electron/electron/pull/42982/files/7b03c0703d7819add6afd022ec97a55b7a2aa268#r1703444772

* docs(api-history): move migration guide

Reference: #42982 (comment)

* docs(api-history): update `breaking-changer-header`

Reference: #43217

* docs(api-history): deprecate `browser-view.md`

---------

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📓 merged/32-x-y PR was merged to the "32-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants