chore: lint code blocks in docs with ESLint#42113
Merged
VerteDinde merged 1 commit intomainfrom May 29, 2025
Merged
Conversation
925a227 to
f448ad2
Compare
3a0ce70 to
469c00e
Compare
6539312 to
9ad8bc7
Compare
9ad8bc7 to
210f1a4
Compare
210f1a4 to
502940b
Compare
502940b to
a306f00
Compare
erickzhao
reviewed
May 27, 2025
Comment on lines
+13
to
+33
| "@typescript-eslint/no-unused-vars": "off", | ||
| "indent": "off", | ||
| "no-undef": "off", | ||
| "no-unused-expressions": "off", | ||
| "no-unused-vars": "off", | ||
| "semi": "off", | ||
| "unicorn/prefer-node-protocol": "error" |
Member
There was a problem hiding this comment.
should we extends: standard as shorthand here?
Member
Author
There was a problem hiding this comment.
I've added that and dropped a couple of these rules (semi: off and indent: off) by excluding a couple more blocks from specific ESLint rules. The rest of these are actually the inverse of what they'd be in standard, specifically turning off unused/undefined checking because a lot of our code blocks are fragments which trip those rules, and that's fine for docs.
ba5bc0b to
0661b7b
Compare
0661b7b to
390fb12
Compare
VerteDinde
approved these changes
May 29, 2025
|
No Release Notes |
1 task
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Main motivation at the moment is to run
unicorn/prefer-node-protocolover the code blocks, but it may also catch some other errors as well.cc @electron/docs
Checklist
Release Notes
Notes: none