Skip to content

chore: bump chromium to 122.0.6194.0 (29-x-y)#40872

Merged
jkleinsc merged 55 commits into29-x-yfrom
trop/29-x-y-bp-chore-bump-chromium-to-122-0-6194-0-main--1704271980508
Jan 4, 2024
Merged

chore: bump chromium to 122.0.6194.0 (29-x-y)#40872
jkleinsc merged 55 commits into29-x-yfrom
trop/29-x-y-bp-chore-bump-chromium-to-122-0-6194-0-main--1704271980508

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jan 3, 2024

Backport of #40750

See that PR for details.

Notes: Updated Chromium to 122.0.6194.0.

trop bot and others added 30 commits January 3, 2024 08:53
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532

minor manual changes to match upstream changes

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299

Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156

no manual changes; patch applied with fuzz 1

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072

minor manual changes to match upstream changes

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481

no manual changes; patch applied with fuzz 2

Co-authored-by: Charles Kerr <charles@charleskerr.com>
…ting.patch

Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253

The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on #40741 ...

Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017

It appears it is not used by anything within Chromium or outside.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872

The copy construtor is more expensive and has been removed upstream

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094

Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.

We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.

This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
….patch

Co-authored-by: Charles Kerr <charles@charleskerr.com>
…ting.patch

The previous experiment of removing the DCHECK in 3509378 was a huge
failure. We either need to either:

A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround

This commit is the first half of option A, removing the patch to use
upstream as-is.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619

minor manual changes to match upstream changes

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922

minor manual changes to match upstream changes

Co-authored-by: Charles Kerr <charles@charleskerr.com>
…g.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595

no manual changes; patch applied with fuzz 1

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
trop bot and others added 18 commits January 3, 2024 08:54
Co-authored-by: deepak1556 <hop2deep@gmail.com>
…api_changes.patch

Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from a team as code owners January 3, 2024 08:55
@trop trop bot added 29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 3, 2024
@jkleinsc jkleinsc merged commit e1ec17d into 29-x-y Jan 4, 2024
@jkleinsc jkleinsc deleted the trop/29-x-y-bp-chore-bump-chromium-to-122-0-6194-0-main--1704271980508 branch January 4, 2024 21:17
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2024

Release Notes Persisted

Updated Chromium to 122.0.6194.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants