-
Notifications
You must be signed in to change notification settings - Fork 17k
Closed
Labels
stale-exemptUsed to indicate that stale automation should not run. Must be accompanied by a comment for whyUsed to indicate that stale automation should not run. Must be accompanied by a comment for whyupgrade-follow-upStuff left to do after a Chromium upgrade.Stuff left to do after a Chromium upgrade.
Description
Discussed at #40632 (comment)
https://chromium-review.googlesource.com/c/v8/v8/+/5075293 made this change:
- if (i_isolate->is_execution_terminating()) { \
- return bailout_value; \
- }
+ DCHECK(!i_isolate->is_execution_terminating()); \At first glance it looks like our code may have been re-entering while terminating prior to this roll & the only change is that now this is a DCHECK()able state. We should track the source of this failure down, fix it, and remove the revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch patch.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
stale-exemptUsed to indicate that stale automation should not run. Must be accompanied by a comment for whyUsed to indicate that stale automation should not run. Must be accompanied by a comment for whyupgrade-follow-upStuff left to do after a Chromium upgrade.Stuff left to do after a Chromium upgrade.