Skip to content

track down origin of is_execution_terminating() DCHECK #40741

@ckerr

Description

@ckerr

Discussed at #40632 (comment)

https://chromium-review.googlesource.com/c/v8/v8/+/5075293 made this change:

-  if (i_isolate->is_execution_terminating()) {                      \
-    return bailout_value;                                           \
-  }                                                                 
+  DCHECK(!i_isolate->is_execution_terminating());                   \

At first glance it looks like our code may have been re-entering while terminating prior to this roll & the only change is that now this is a DCHECK()able state. We should track the source of this failure down, fix it, and remove the revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch patch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    stale-exemptUsed to indicate that stale automation should not run. Must be accompanied by a comment for whyupgrade-follow-upStuff left to do after a Chromium upgrade.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions