fix: titlebar incorrectly displayed on frameless windows by brhenrique · Pull Request #40749 · electron/electron

brhenrique · 2023-12-12T12:42:08Z

Description of Change

Fixes a bug where Mica background won't work without the transparent: true setting
Fixes a bug where a title bar is displayed on frameless windows

A patch was added to fix Mica backgrounds on frameless windows, but it caused a side-effect in which a title bar gets displayed on frameless transparent windows.

This happens because, after the patch, WM_NCACTIVATE would be dispatched to DefWindowProc for frameless transparent windows. While this is necessary to make Mica work on these windows, it would cause an incorrect title bar to also be displayed.

To fix this, we are setting -1 as the lParam of DefWindowProc, which seems to prevent the non-client area from being displayed on window activation/deactivation:

When a visual style is not active for this window, this parameter is a handle to an optional update region for the nonclient area of the window. If this parameter is set to -1, DefWindowProc does not repaint the nonclient area to reflect the state change.

	Transparent: False, Mica	Transparent: True, Frame: False, Mica	Transparent: True, Frame: True, Mica	Transparent: True, Frame: False, No Mica
Mica Before	❌	❌	✅	-
Mica After	✅	❌	✅	-
Title Bar Before	-	❌	✅	❌
Title Bar After	-	✅	✅	✅

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation, tutorials, templates and examples are changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fix incorrect title bar shown on frameless transparent windows

brhenrique · 2023-12-12T12:43:44Z

cc @zcbenz @clavin

michalzaq12 · 2023-12-15T11:43:22Z

Good job, but I noticed two things (regarding frameless window):

strange behavior when we set transparet: true with Mica enabled. Mica does not work on initial page load. But it starts working after resizing the window. Without transparet: true, mica works as intended.
Maximizing a window with Mica enabled, causes the entire window to crash

brhenrique · 2023-12-15T15:00:41Z

Good job, but I noticed two things (regarding frameless window):

strange behavior when we set transparet: true with Mica enabled. Mica does not work on initial page load. But it starts working after resizing the window. Without transparet: true, mica works as intended.

Maximizing a window with Mica enabled, causes the entire window to crash

I see, but both issues seem to also be present in the latest stable, right? I think there should be a separate PR for them, since this one is focused on different problems.

Cloudkkk · 2023-12-18T03:19:04Z

🥹Is there any blocking point for this PR? When can we expect it to be fixed? It's really important to me. Thanks

clavin

Well done! Thank you so much for investigating and fixing this 😊

I have built and manually tested this change and can confirm it works. ✅

I have one small change to request 😅 but after that this should be good to merge. I'll also make sure the backports for this PR land swiftly after.

shell/browser/ui/win/electron_desktop_window_tree_host_win.cc

Auhnip · 2023-12-22T02:34:53Z

I recently came across this pull request and noticed that it contains the exact fix I need for a bug that's been a bit of a roadblock for me. Is there any chance it could be reviewed and merged soon? It's important to me. thanks~

clavin

I went and pushed the change I described to your branch—I hope that's alright—so that we can get this fix merged asap 😄

release-clerk · 2024-01-02T18:59:51Z

Release Notes Persisted

fix incorrect title bar shown on frameless transparent windows

trop · 2024-01-02T19:00:05Z

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

trop · 2024-01-02T19:00:08Z

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

trop · 2024-01-02T19:00:32Z

I have automatically backported this PR to "29-x-y", please check out #40862

Manual backport of #40749 Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

trop · 2024-01-03T00:02:03Z

@clavin has manually backported this PR to "28-x-y", please check out #40867

Manual backport of #40749 (a208d45) Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

trop · 2024-01-03T00:19:16Z

@clavin has manually backported this PR to "27-x-y", please check out #40868

Manual backport of #40749 (a208d45) Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

Manual backport of #40749 Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

wujunliang · 2025-08-04T03:49:58Z

37.2.5还是有这个bug

fix: titlebar incorrectly displayed on frameless windows

5050e1b

brhenrique requested a review from a team as a code owner December 12, 2023 12:42

electron-cation bot added the new-pr 🌱 PR opened recently label Dec 12, 2023

brhenrique mentioned this pull request Dec 12, 2023

fix: titlebar incorrectly displayed on frameless windows #40395

Closed

5 tasks

zcbenz added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Dec 13, 2023

zcbenz approved these changes Dec 13, 2023

View reviewed changes

Marocco2 mentioned this pull request Dec 13, 2023

Remove transparent: true for transparencyOption Vencord/Vesktop#266

Merged

electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 13, 2023

fix: enable transparency for Mica windows

eb19637

clavin self-requested a review December 19, 2023 19:12

clavin requested changes Dec 19, 2023

View reviewed changes

shell/browser/ui/win/electron_desktop_window_tree_host_win.cc Outdated Show resolved Hide resolved

ckerr approved these changes Dec 19, 2023

View reviewed changes

Refactor ShouldWindowContentsBeTransparent

db47852

clavin approved these changes Dec 26, 2023

View reviewed changes

jkleinsc merged commit a208d45 into electron:main Jan 2, 2024

trop bot removed the target/27-x-y PR should also be added to the "27-x-y" branch. label Jan 2, 2024

trop bot added needs-manual-bp/27-x-y needs-manual-bp/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Jan 2, 2024

trop bot mentioned this pull request Jan 2, 2024

fix: titlebar incorrectly displayed on frameless windows #40862

Merged

trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y labels Jan 2, 2024

clavin added a commit that referenced this pull request Jan 2, 2024

fix: titlebar incorrectly displayed on frameless windows

09f93a5

Manual backport of #40749 Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

clavin mentioned this pull request Jan 3, 2024

fix: titlebar incorrectly displayed on frameless windows #40867

Merged

trop bot added in-flight/28-x-y and removed needs-manual-bp/28-x-y labels Jan 3, 2024

clavin added a commit that referenced this pull request Jan 3, 2024

fix: titlebar incorrectly displayed on frameless windows

a917645

Manual backport of #40749 (a208d45) Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

clavin mentioned this pull request Jan 3, 2024

fix: titlebar incorrectly displayed on frameless windows #40868

Merged

trop bot added in-flight/27-x-y and removed needs-manual-bp/27-x-y labels Jan 3, 2024

codebytere pushed a commit that referenced this pull request Jan 3, 2024

fix: titlebar incorrectly displayed on frameless windows (#40868)

8471e47

Manual backport of #40749 (a208d45) Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

trop bot added merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/27-x-y in-flight/28-x-y labels Jan 3, 2024

codebytere pushed a commit that referenced this pull request Jan 3, 2024

fix: titlebar incorrectly displayed on frameless windows (#40867)

0b8f962

Manual backport of #40749 Co-authored-by: Bruno Henrique da Silva <bruno.d@miro.com>

trop bot added the merged/28-x-y PR was merged to the "28-x-y" branch. label Jan 3, 2024

illixion mentioned this pull request Jul 26, 2025

Tabbed and Mica material Please! illixion/vscode-vibrancy-continued#19

Open

Conversation

brhenrique commented Dec 12, 2023 • edited by clavin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

brhenrique commented Dec 12, 2023

Uh oh!

michalzaq12 commented Dec 15, 2023

Uh oh!

brhenrique commented Dec 15, 2023

Uh oh!

Cloudkkk commented Dec 18, 2023

Uh oh!

clavin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Auhnip commented Dec 22, 2023

Uh oh!

clavin left a comment

Choose a reason for hiding this comment

Uh oh!

release-clerk bot commented Jan 2, 2024

Uh oh!

trop bot commented Jan 2, 2024

Uh oh!

trop bot commented Jan 2, 2024

Uh oh!

trop bot commented Jan 2, 2024

Uh oh!

trop bot commented Jan 3, 2024

Uh oh!

trop bot commented Jan 3, 2024

Uh oh!

wujunliang commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

brhenrique commented Dec 12, 2023 •

edited by clavin

Loading

clavin left a comment •

edited

Loading