Skip to content

docs: avoid leaking the IpcRendererEvent in contextBridge examples#40321

Merged
codebytere merged 4 commits intomainfrom
miniak/docs-ipc
Nov 1, 2023
Merged

docs: avoid leaking the IpcRendererEvent in contextBridge examples#40321
codebytere merged 4 commits intomainfrom
miniak/docs-ipc

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Oct 24, 2023

Notes: none

@miniak miniak requested a review from dsanders11 October 24, 2023 20:38
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Oct 24, 2023
@miniak miniak requested a review from erickzhao October 24, 2023 20:38
@miniak miniak added the target/28-x-y PR should also be added to the "28-x-y" branch. label Oct 24, 2023
dsanders11
dsanders11 reviewed Oct 25, 2023
View reviewed changes
miniak and others added 3 commits October 25, 2023 16:56
@miniak @dsanders11
Update docs/fiddles/ipc/pattern-3/preload.js
5aa7d01 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@miniak @dsanders11
Update docs/tutorial/ipc.md
ad6877c 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@miniak @dsanders11
Update docs/tutorial/ipc.md
b7a1ed7 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@miniak miniak added the target/27-x-y PR should also be added to the "27-x-y" branch. label Oct 25, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 25, 2023
@miniak miniak self-assigned this Oct 26, 2023
@codebytere codebytere requested a review from dsanders11 October 30, 2023 11:21
@dsanders11 dsanders11 mentioned this pull request Oct 30, 2023
Merged
@codebytere codebytere merged commit b163187 into main Nov 1, 2023
@codebytere codebytere deleted the miniak/docs-ipc branch November 1, 2023 17:46
@release-clerk
Copy link

release-clerk bot commented Nov 1, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Nov 1, 2023

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Nov 1, 2023
@trop trop bot mentioned this pull request Nov 1, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Nov 1, 2023

I have automatically backported this PR to "28-x-y", please check out #40412

@trop trop bot added in-flight/28-x-y merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/28-x-y labels Nov 1, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak @dsanders11
docs: avoid leaking the IpcRendererEvent in contextBridge examples (
a3a19f2 
electron#40321)

* docs: avoid leaking the `IpcRendererEvent` in `contextBridge` examples

* Update docs/fiddles/ipc/pattern-3/preload.js

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* Update docs/tutorial/ipc.md

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* Update docs/tutorial/ipc.md

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

---------

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao Awaiting requested review from erickzhao

Assignees

@miniak miniak

Labels

documentation 📓 merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miniak @codebytere @dsanders11 @jkleinsc