Skip to content

fix: error using webcrypto.subtle.importKey() #40070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 1 commit into from
Oct 5, 2023
Merged

fix: error using webcrypto.subtle.importKey() #40070

codebytere merged 1 commit into from
Oct 5, 2023

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Oct 2, 2023

Description of Change

Closes #40002.
Refs nodejs/node#46067.

Fixes an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

Checklist

Release Notes

Notes: Fixed an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 2, 2023
@codebytere codebytere requested a review from a team as a code owner October 2, 2023 14:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 2, 2023
jkleinsc
jkleinsc approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 3, 2023
@codebytere codebytere force-pushed the crypto-aes-key-undefined branch from 5dcaac6 to 495f6a1 Compare October 4, 2023 08:41
@codebytere codebytere mentioned this pull request Oct 4, 2023
Merged
@codebytere codebytere merged commit b3a1c6d into main Oct 5, 2023
@codebytere codebytere deleted the crypto-aes-key-undefined branch October 5, 2023 08:46
@release-clerk
Copy link

release-clerk bot commented Oct 5, 2023

Release Notes Persisted

Fixed an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

@trop trop bot mentioned this pull request Oct 5, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 5, 2023

I have automatically backported this PR to "27-x-y", please check out #40100

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Oct 5, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: error using webcrypto.subtle.importKey() (electron#40070)
139a80f 
fix: error using webcrypto.subtle.importKey()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: SubtleCrypto.importKey crash with "Cannot read properties of undefined" on Electron 27 Beta

3 participants

@codebytere @jkleinsc