fix: cookies filter secure invalid#37203
Merged
codebytere merged 9 commits intoelectron:mainfrom Feb 13, 2023
Merged
Conversation
codebytere
requested changes
Feb 9, 2023
Member
codebytere
left a comment
There was a problem hiding this comment.
Can you please describe the issue in more detail as well as properly fill out the PR template? Additionally, we should have some tests for this.
711a629 to
c954841
Compare
Member
Author
|
@codebytere Description updated and already add tests. |
deepak1556
approved these changes
Feb 9, 2023
Member
|
@BlackHole1 can you update the |
Co-authored-by: Robo <hop2deep@gmail.com>
Member
Author
|
@deepak1556 Done. I updated the |
zcbenz
approved these changes
Feb 13, 2023
codebytere
approved these changes
Feb 13, 2023
|
Release Notes Persisted
|
This was referenced Feb 13, 2023
Contributor
|
I have automatically backported this PR to "24-x-y", please check out #37246 |
Contributor
|
I have automatically backported this PR to "22-x-y", please check out #37247 |
Contributor
|
I have automatically backported this PR to "23-x-y", please check out #37248 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
gist: https://gist.github.com/6d2ba80a835a75f90f385a2f4664a6a0
This is a simple judgment condition error that just needs to be corrected to the correct judgment condition.
Checklist
npm testpassesRelease Notes
Notes: Fixed an incorrect result returned when using secure as a cookies filter.