Skip to content

docs: document that when invoke rejects, it gives a different Error #36127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nornagon merged 1 commit into from
Oct 26, 2022
Merged

docs: document that when invoke rejects, it gives a different Error #36127

nornagon merged 1 commit into from
Oct 26, 2022

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Oct 25, 2022 •
edited
Loading

Description of Change

Closes #24427.

I don't think we want to change the serialization behavior of Error here, but enough people have tripped over this that it deserves a mention in the docs.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added

Release Notes

Notes: none

@nornagon nornagon added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 25, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Oct 25, 2022
@nornagon nornagon added semver/none and removed semver/patch backwards-compatible bug fixes labels Oct 25, 2022
@electron-cation electron-cation bot added the semver/patch backwards-compatible bug fixes label Oct 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 26, 2022
@nornagon
Copy link
Contributor Author

nornagon commented Oct 26, 2022

cation seems to be insisting this is semver/patch, which doesn't seem right to me but whatever.

@nornagon nornagon merged commit a75e8e0 into main Oct 26, 2022
@nornagon nornagon deleted the nornagon-patch-1 branch October 26, 2022 20:56
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2022

No Release Notes

This was referenced Oct 26, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "20-x-y", please check out #36146

@trop trop bot mentioned this pull request Oct 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "21-x-y", please check out #36147

@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "22-x-y", please check out #36148

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 26, 2022
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. merged/20-x-y and removed in-flight/22-x-y labels Oct 27, 2022
@commit-lint commit-lint bot mentioned this pull request Feb 16, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
docs: document that when invoke rejects, it gives a different Error (…
6fc4924 
…electron#36127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ipcRenderer.invoke can't handle custom errors

4 participants

@nornagon @zcbenz @codebytere