Conversation
jkleinsc
reviewed
Sep 7, 2022
erickzhao
reviewed
Sep 7, 2022
codebytere
reviewed
Sep 8, 2022
ckerr
reviewed
Sep 13, 2022
Member
|
API LGTM |
|
Release Notes Persisted
|
3 tasks
3 tasks
3 tasks
3 tasks
|
|
Contributor
Author
|
@PascalPixel please open a new issue with a repro, thanks! |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: add webContents.close() * update docs, add test for beforeunload override * Update web-contents.md
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds
webContents.close(), which has roughly the same effect as the pagecalling
window.close(). Closes #26929.There was some discussion in #26929 about having a WebContents be reusable
after close, but after studying the //content API for a while, I'm not sure
that's reasonable to implement, since content::WebContents is only closable by
destroying it.
Checklist
npm testpassesRelease Notes
Notes: Added
webContents.close()method.