Skip to content

fix: screen.getCursorScreenPoint() crash on Wayland#35503

Merged
codebytere merged 1 commit intomainfrom
fix-wayland-crash
Sep 5, 2022
Merged

fix: screen.getCursorScreenPoint() crash on Wayland#35503
codebytere merged 1 commit intomainfrom
fix-wayland-crash

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Aug 30, 2022

Description of Change

Closes #35471.

Fixes an issue where screen.getCursorScreenPoint() crashed on Wayland when it was called before a BrowserWindow had been created. This happened becuase the Wayland implementation requires it. To fix this, we throw an error if a user attempts to call it before creating a BrowserWindow.

Checklist

Release Notes

Notes: Fixed an issue where screen.getCursorScreenPoint() crashed on Wayland when it was called before a BrowserWindow had been created.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 30, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 30, 2022
ckerr
ckerr reviewed Aug 30, 2022
View reviewed changes
@codebytere codebytere force-pushed the fix-wayland-crash branch 2 times, most recently from 01f4fcc to faa7432 Compare August 30, 2022 17:08
@codebytere codebytere requested a review from ckerr August 31, 2022 08:08
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 31, 2022
@codebytere codebytere merged commit 2db0f7f into main Sep 5, 2022
@codebytere codebytere deleted the fix-wayland-crash branch September 5, 2022 08:10
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Sep 5, 2022

Release Notes Persisted

Fixed an issue where screen.getCursorScreenPoint() crashed on Wayland when it was called before a BrowserWindow had been created.

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 5, 2022

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Sep 5, 2022
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 5, 2022

I have automatically backported this PR to "21-x-y", please check out #35575

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Sep 5, 2022
@commit-lint commit-lint bot mentioned this pull request Dec 1, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: screen.getCursorScreenPoint() crash on Wayland (electron#35503)
f0e3ed6 
fix: screen.getCursorScreenPoint() crash on Wayland
This was referenced Mar 5, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees

No one assigned

Labels

merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Segfault when calling screen.getCursorScreenPoint() under Wayland

4 participants

@codebytere @ckerr @VerteDinde @miniak