Skip to content

chore: deprecate nativeWindowOpen in Electron 17#32116

Merged
VerteDinde merged 1 commit intomainfrom
miniak/deprecate-native-window-open
Jan 6, 2022
Merged

chore: deprecate nativeWindowOpen in Electron 17#32116
VerteDinde merged 1 commit intomainfrom
miniak/deprecate-native-window-open

Conversation

@miniak
Copy link
Copy Markdown
Contributor

@miniak miniak commented Dec 6, 2021

Description of Change

Prepare for #29405

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@miniak miniak self-assigned this Dec 6, 2021
@miniak miniak added semver/major incompatible API changes target/17-x-y labels Dec 6, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 13, 2021
nornagon
nornagon reviewed Jan 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add warnings or something? Or are they already in place?

@miniak miniak force-pushed the miniak/deprecate-native-window-open branch from 5b3bdfa to 811f344 Compare January 4, 2022 20:16
@miniak
Copy link
Copy Markdown
Contributor Author

miniak commented Jan 4, 2022

@nornagon good point, yes, we should add a warning

@miniak miniak force-pushed the miniak/deprecate-native-window-open branch from 811f344 to 292e0b3 Compare January 6, 2022 01:09
jkleinsc
jkleinsc approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

codebytere
codebytere approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@VerteDinde VerteDinde merged commit 2f9fd06 into main Jan 6, 2022
@VerteDinde VerteDinde deleted the miniak/deprecate-native-window-open branch January 6, 2022 13:09
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Jan 6, 2022

No Release Notes

@trop trop bot mentioned this pull request Jan 6, 2022
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Jan 6, 2022

I have automatically backported this PR to "17-x-y", please check out #32368

@miniak miniak mentioned this pull request Jan 6, 2022
Merged
5 tasks
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@miniak @t57ser
chore: deprecate nativeWindowOpen in Electron 17 (electron#32116)
fec620b
@commit-lint commit-lint bot mentioned this pull request Mar 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

+2 more reviewers

@nornagon nornagon nornagon left review comments

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miniak miniak

Labels

api-review/approved ✅ semver/major incompatible API changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miniak @nornagon @jkleinsc @zcbenz @codebytere @VerteDinde