fix: don't propagate GDK_BACKEND to subprocs#28898
Merged
codebytere merged 5 commits intomainfrom Jun 8, 2021
Merged
Conversation
MarshallOfSound
approved these changes
Apr 28, 2021
deepak1556
reviewed
Apr 29, 2021
bb623c5 to
4f53a61
Compare
zcbenz
suggested changes
May 5, 2021
f530859 to
cac2e3b
Compare
zcbenz
reviewed
May 6, 2021
zcbenz
reviewed
May 6, 2021
cac2e3b to
2f5a448
Compare
zcbenz
reviewed
May 19, 2021
Contributor
zcbenz
left a comment
There was a problem hiding this comment.
The code looks good to me, I think we just need a test to check if GDK_BACKEND has actually been cleared.
2f5a448 to
fc649bb
Compare
vially
reviewed
May 19, 2021
| options.environment["MM_NOTTTY"] = "1"; | ||
|
|
||
| // If the user set a GDK_BACKEND value of their own, use that, | ||
| // otherwise unset it becuase Chromium is setting GDK_BACKEND |
Contributor
There was a problem hiding this comment.
Small typo (nitpick): becuase => because
zcbenz
approved these changes
Jun 8, 2021
fc649bb to
3edf8ad
Compare
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "12-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "13-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "14-x-y", please check out #29588 |
codebytere
added a commit
that referenced
this pull request
Jun 9, 2021
3 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Jun 9, 2021
This reverts commit 7b169c2.
MarshallOfSound
added a commit
that referenced
this pull request
Jun 9, 2021
ckerr
pushed a commit
that referenced
this pull request
Jun 9, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #28436.
GDK_BACKENDis set by Chromium as of this CL and can detrimentally affect external app behaviors, so we want to unset it and replace with the user's setting if one exists.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
GDK_BACKENDwas being propagated to subprocesses on Linux.