Skip to content

feat: enable nativeWindowOpen by default#28552

Merged
jkleinsc merged 8 commits intomasterfrom
nativewindowopen-default
Apr 13, 2021
Merged

feat: enable nativeWindowOpen by default#28552
jkleinsc merged 8 commits intomasterfrom
nativewindowopen-default

Conversation

@nornagon
Copy link
Copy Markdown
Contributor

@nornagon nornagon commented Apr 6, 2021

Description of Change

Make nativeWindowOpen: true the default.

This option has been better than the alternative for some time (fewer bugs,
faster new windows, and more flexible). Let's make it the default.

Closes #28511.

Checklist

Release Notes

Notes: nativeWindowOpen: true is now the default.

@nornagon nornagon added the semver/major incompatible API changes label Apr 6, 2021
@nornagon nornagon force-pushed the nativewindowopen-default branch from 899df58 to d534336 Compare April 6, 2021 20:04
miniak
miniak requested changes Apr 7, 2021
View reviewed changes
@nornagon nornagon force-pushed the nativewindowopen-default branch from 0dc8a15 to 024d69d Compare April 9, 2021 00:35
@nornagon nornagon requested a review from miniak April 9, 2021 17:15
@jkleinsc jkleinsc merged commit f8bdef5 into master Apr 13, 2021
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Apr 13, 2021

Release Notes Persisted

nativeWindowOpen: true is now the default.

@jkleinsc jkleinsc deleted the nativewindowopen-default branch April 13, 2021 19:36
@nornagon nornagon mentioned this pull request Apr 20, 2021
Closed
3 tasks
@CezaryKulakowski CezaryKulakowski mentioned this pull request May 10, 2021
Open
3 tasks
@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
@MarshallOfSound MarshallOfSound mentioned this pull request Jun 14, 2021
Closed
3 tasks
@nornagon nornagon mentioned this pull request Jun 23, 2021
Merged
5 tasks
nornagon added a commit that referenced this pull request Jun 23, 2021
@nornagon
Revert "feat: enable nativeWindowOpen by default (#28552)"
fa27728 
This reverts commit f8bdef5.
zcbenz pushed a commit that referenced this pull request Jun 28, 2021
@nornagon
feat: undo nativeWindowOpen default change, warn instead (#29869)
5530497 
* Revert "feat: enable nativeWindowOpen by default (#28552)"

This reverts commit f8bdef5.

* warn when nativeWindowOpen is undefined

* Update browser-window.md
@miniak miniak mentioned this pull request Oct 7, 2021
Merged
3 tasks
@koizuka koizuka mentioned this pull request Nov 20, 2021
Merged
@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-review/requested 🗳 new-pr 🌱 PR opened recently semver/major incompatible API changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make nativeWindowOpen: true the default

5 participants

@nornagon @jkleinsc @zcbenz @miniak @codebytere