Skip to content

fix: pass postData to new-window event#28513

Merged
nornagon merged 5 commits intomasterfrom
nornagon-patch-2
Apr 6, 2021
Merged

fix: pass postData to new-window event#28513
nornagon merged 5 commits intomasterfrom
nornagon-patch-2

Conversation

@nornagon
Copy link
Copy Markdown
Contributor

@nornagon nornagon commented Apr 5, 2021

Description of Change

This adds the missing postData parameter to new-window, which was previously omitted. This is the only call site of emitDeprecatedNewWindowEvent, so I can only assume its omission was accidental.

Checklist

Release Notes

Notes: Fixed postData parameter missing from new-window event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 5, 2021
@nornagon nornagon added target/12-x-y semver/patch backwards-compatible bug fixes labels Apr 5, 2021
@nornagon nornagon mentioned this pull request Apr 5, 2021
Merged
5 tasks
@nornagon
Copy link
Copy Markdown
Contributor Author

nornagon commented Apr 6, 2021

asan failure unrelated.

@nornagon nornagon merged commit 77dcf10 into master Apr 6, 2021
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Apr 6, 2021

Release Notes Persisted

Fixed postData parameter missing from new-window event.

@nornagon nornagon deleted the nornagon-patch-2 branch April 6, 2021 16:54
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Apr 6, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Apr 6, 2021
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Apr 6, 2021

I have automatically backported this PR to "13-x-y", please check out #28542

@nornagon nornagon mentioned this pull request Apr 6, 2021
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Apr 6, 2021

@nornagon has manually backported this PR to "12-x-y", please check out #28543

nornagon added a commit that referenced this pull request Apr 6, 2021
@nornagon
fix: pass postData to new-window event (#28513)
fc7f337
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 7, 2021
zcbenz pushed a commit that referenced this pull request Apr 7, 2021
@nornagon
fix: pass postData to new-window event (#28543)
337e691 
* fix: pass postData to new-window event (#28513)

* Update api-browser-window-spec.ts
@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nornagon @codebytere