Skip to content

Fix debugger not working for main process#2608

Merged
zcbenz merged 5 commits into
masterfrom
fix-debugger
Aug 27, 2015
Merged

Fix debugger not working for main process#2608
zcbenz merged 5 commits into
masterfrom
fix-debugger

Conversation

@zcbenz

@zcbenz zcbenz commented Aug 27, 2015

Copy link
Copy Markdown
Contributor

Node's own implementation of debug agent is not very suitable for being embedded with Electron, this PR brings back our own implementation to fix the problems.

Closes #2562.
Closes #2335.

zcbenz added a commit that referenced this pull request Aug 27, 2015
Fix debugger not working for main process
@zcbenz zcbenz merged commit 0ddf908 into master Aug 27, 2015
@zcbenz zcbenz deleted the fix-debugger branch August 27, 2015 06:28
@Hum4n01d

Copy link
Copy Markdown

I’m still getting this issue when trying to debug in both VSCode and PyCharm (I don’t think it’s related to the editors)

theproject/node_modules/.bin/electron —debug-brk=65056 --expose_debug_as=v8debug theproject/src/main.js
App threw an error during load
Error: Cannot find module 'theproject/src/—debug-brk=65056'
    at Module._resolveFilename (module.js:470:15)

I replaced the absolute paths with theproject for privacy 😉

@Hum4n01d

Copy link
Copy Markdown

Ah, never mind. I found the problem. It’s in electron-prebuilt-compile electron-userland/electron-prebuilt-compile#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.31.0] forking with --debug from renderer closes streams instantly --debug-brk doesn't work

2 participants