Fix message box missing a close button on Windows#2556
Merged
Conversation
added 2 commits
August 22, 2015 04:20
Contributor
|
Looks good to me, thanks! |
zcbenz
added a commit
that referenced
this pull request
Aug 25, 2015
Fix message box missing a close button on Windows
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #2293.
The issue was that on Windows the close button (the
Xin the dialog's border) was visible only ifcancelIdwasn't 0. This is weird, because it means that no dialog that contains a single button will ever have a close button (e.g. thealertdialog). The OS X and Linux implementation doesn't do that. So I changed the Windows code, to always show the close button.I added two additional small changes:
alertto always returnundefinedinstead of 0 (the index of theOKbutton), so it will comply with the spec (or at least how most browsers choose to implement it).cancelIdforconfirmto 1. The button on index 1 isCanceland according to the documentationcancelIdwill automatically be set to it in the Windows and OS X implementation. This change makes sure that Linux will use the samecancelId.