Skip to content

Use NSImageView to draw tray icon.#2370

Merged
zcbenz merged 1 commit intomasterfrom
osx-tray
Jul 29, 2015
Merged

Use NSImageView to draw tray icon.#2370
zcbenz merged 1 commit intomasterfrom
osx-tray

Conversation

@hokein
Copy link
Copy Markdown
Contributor

@hokein hokein commented Jul 29, 2015

This PR fixes a couple of tray issues causing by #2232 .

  • Fixes Tray Icon horizontally stretched #2360. It's caused by forcing the icon with to 26px. Some more, the native NSStatusItem implmentation will draw 4px to the image as left and right padding margin, in StatusItemView, we need to simulate its behavior manually.
  • Fixes Tempate image doesn't show correctly in dark mode.
  • Fixes title color will not reversed in dark mode.

* Fixes Tempate image doesn't show correctly in dark mode.
* Fixes the tray icon is stretched showing in menubar.
* Fixes title color will not reversed in dark mode.
@zcbenz
Copy link
Copy Markdown
Contributor

zcbenz commented Jul 29, 2015

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tray Icon horizontally stretched

2 participants