clipboard: api to list supported types, reading and writing markup#1752
Merged
zcbenz merged 2 commits intoelectron:masterfrom May 28, 2015
Merged
clipboard: api to list supported types, reading and writing markup#1752zcbenz merged 2 commits intoelectron:masterfrom
zcbenz merged 2 commits intoelectron:masterfrom
Conversation
7d21f32 to
b59e4df
Compare
Contributor
There was a problem hiding this comment.
I think we should keep the clipboard.has API, most use cases tend to test specified type instead of iterating all types.
Member
Author
There was a problem hiding this comment.
The format parameter in has api is a bit misleading as its actually deduced from the string passed, should we make it clear in the docs ?
Contributor
There was a problem hiding this comment.
The format parameter in has api is a bit misleading as its actually deduced from the string passed, should we make it clear in the docs ?
Sounds good to me.
b59e4df to
4d56281
Compare
Contributor
|
Thanks! |
zcbenz
added a commit
that referenced
this pull request
May 28, 2015
clipboard: api to list supported types, reading and writing markup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1729
Have removed
has(format)api , since its no use withavailableFormats. Also we have a genericReadapi which can read to the supported type but doesnt respond what type it is, can we remove that and just leave with the explicit types [text,html,bitmap,rtf] ?