fix: Disable new fade animation for BrowserViews#14911
Merged
MarshallOfSound merged 1 commit intomasterfrom Oct 2, 2018
Merged
fix: Disable new fade animation for BrowserViews#14911MarshallOfSound merged 1 commit intomasterfrom
MarshallOfSound merged 1 commit intomasterfrom
Conversation
nornagon
approved these changes
Oct 1, 2018
|
Release Notes Persisted
|
Contributor
|
We have automatically backported this PR to "3-0-x", please check out #14913 |
PalmerAL
added a commit
to minbrowser/min
that referenced
this pull request
Oct 26, 2018
this was fixed in electron/electron#14911
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
With
3.x, we switched to a newer version of the macOS SDK. With that came a subtle change: An implicit animation is applied to BrowserViews, since they're addedNSViewsubviews. I didn't think much of it at the time, but our designers did not appreciate the surprise change – and I can understand why 😁This PR ensures that we don't show a cross-fade animation while adding or removing a
BrowserView, ensuring thatBrowserViewsbehave just like they have in Electron2.x.Closes #14909
Before
After
Checklist
npm testpassesRelease Notes
Notes: Removed an accidentially added fade animation to
BrowserViews