Fix node::AtExit() crash in Chromium 62 upgrade#11708
Merged
codebytere merged 1 commit intoupgrade-to-chromium-62from Jan 24, 2018
Merged
Fix node::AtExit() crash in Chromium 62 upgrade#11708codebytere merged 1 commit intoupgrade-to-chromium-62from
codebytere merged 1 commit intoupgrade-to-chromium-62from
Conversation
alexeykuzmin
approved these changes
Jan 23, 2018
zcbenz
pushed a commit
that referenced
this pull request
Jan 31, 2018
alexeykuzmin
pushed a commit
that referenced
this pull request
Feb 21, 2018
alexeykuzmin
pushed a commit
that referenced
this pull request
Feb 22, 2018
zcbenz
pushed a commit
that referenced
this pull request
Feb 23, 2018
zcbenz
pushed a commit
that referenced
this pull request
Feb 23, 2018
sethlu
pushed a commit
to sethlu/electron
that referenced
this pull request
May 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11299 in chromium 62 upgrade by preventing crashes in loading native module with node::AtExit()
/cc @alexeykuzmin @brenca