-
Notifications
You must be signed in to change notification settings - Fork 17k
Closed
Labels
22-x-y23-x-ybug 🪲component/BrowserViewcomponent/webcontentscrash 💥has-repro-gistIssue can be reproduced with code at https://gist.github.com/Issue can be reproduced with code at https://gist.github.com/status/confirmedA maintainer reproduced the bug or agreed with the featureA maintainer reproduced the bug or agreed with the feature
Description
Preflight Checklist
- I have read the Contributing Guidelines for this project.
- I agree to follow the Code of Conduct that this project adheres to.
- I have searched the issue tracker for a bug report that matches the one I want to file, without success.
Electron Version
22.2.0
What operating system are you using?
Windows
Operating System Version
Windows 10
What arch are you using?
x64
Last Known Working Electron version
21.4.1
Expected Behavior
If 'beforeunload' event listener for a window has
event.returnValue = false
non of it's child Browser Views are destroyed/closed
Actual Behavior
If 'beforeunload' event listener for a window has
event.returnValue = false
all of it's child Browser Views will be detroyed
Testcase Gist URL
https://gist.github.com/YauheniBH-EF/190ea8ff42c09a15763705ed4647b02e
Additional Information
I have a feeling that it's related to #35509 this PR changes, but i'm not proficient enough in Electron/C++ to check/fix it by myself.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
22-x-y23-x-ybug 🪲component/BrowserViewcomponent/webcontentscrash 💥has-repro-gistIssue can be reproduced with code at https://gist.github.com/Issue can be reproduced with code at https://gist.github.com/status/confirmedA maintainer reproduced the bug or agreed with the featureA maintainer reproduced the bug or agreed with the feature