Skip to content

[DOCS] Adds highlights to the Installation and Upgrade Guide#252

Merged
lcawl merged 3 commits intoelastic:masterfrom
lcawl:upgrade-highlights
Mar 22, 2019
Merged

[DOCS] Adds highlights to the Installation and Upgrade Guide#252
lcawl merged 3 commits intoelastic:masterfrom
lcawl:upgrade-highlights

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Mar 21, 2019

This PR drafts a "Highlights" page in the Installation and Upgrade Guide and re-uses content that's tagged as "notable-highlights" from the Elasticsearch Reference and Kibana Guide.

Depends on elastic/kibana#33675 and elastic/elasticsearch#40330

@nik9000
Copy link
Copy Markdown
Member

nik9000 commented Mar 21, 2019

@lcawl the PR build is working! I'm so happy!

@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Mar 21, 2019

Thanks @nik9000 that's cool! It's giving valid errors due to this PR's dependency on two others.

include::breaking.asciidoc[] No newline at end of file
include::breaking.asciidoc[]

include::highlights.asciidoc[] No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put highlights first?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, done!

@lcawl lcawl merged commit 55755d0 into elastic:master Mar 22, 2019
@lcawl lcawl deleted the upgrade-highlights branch March 22, 2019 21:20
@lcawl lcawl removed the WIP Work in progress label Mar 22, 2019
@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Mar 22, 2019

Backported to 7.x via cac165c

@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Mar 22, 2019

Backported to 7.0 via fda5916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants