Edit max_signals field for custom rules in UI [classic]#5106
Merged
joepeeples merged 11 commits intomainfrom Jul 3, 2024
Merged
Edit max_signals field for custom rules in UI [classic]#5106joepeeples merged 11 commits intomainfrom
max_signals field for custom rules in UI [classic]#5106joepeeples merged 11 commits intomainfrom
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
max_signals field for custom rules in UI [classic]
joepeeples
commented
Apr 23, 2024
banderror
reviewed
Apr 24, 2024
approksiu
reviewed
Apr 25, 2024
Contributor
approksiu
left a comment
There was a problem hiding this comment.
Suggested some changes in a comment
dplumlee
previously approved these changes
Apr 25, 2024
Contributor
dplumlee
left a comment
There was a problem hiding this comment.
This lines up correctly with the logic we have implemented, thanks @joepeeples!
7 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Closed
16 tasks
benironside
approved these changes
Jul 3, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* First draft * Update docs/detections/rules-ui-create.asciidoc * Revise note (in API docs too) * Update ESQL rule steps per https://github.com/elastic/staging-serverless-security-docs/pull/340#issuecomment-2103001892 * Revise alert suppression refs to max_signals * Explain max_signals = Max alerts per run * Add updates to "update rule" API too (cherry picked from commit 3bdfc22)
joepeeples
added a commit
that referenced
this pull request
Jul 3, 2024
) * First draft * Update docs/detections/rules-ui-create.asciidoc * Revise note (in API docs too) * Update ESQL rule steps per https://github.com/elastic/staging-serverless-security-docs/pull/340#issuecomment-2103001892 * Revise alert suppression refs to max_signals * Explain max_signals = Max alerts per run * Add updates to "update rule" API too (cherry picked from commit 3bdfc22) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Do not merge to
mainuntil after 8.14.0 release, maybe until 8.15 feature freeze. This is to avoid adding 8.15 features into previous versions' branches (since those branches would be cut frommain).Contributes to #5029.
Preview
Twin PR for serverless