Skip to content

http_logs add force merge to 1 segment#90

Merged
mayya-sharipova merged 2 commits intoelastic:masterfrom
mayya-sharipova:http-logs-add-merge-1-seg
Nov 14, 2019
Merged

http_logs add force merge to 1 segment#90
mayya-sharipova merged 2 commits intoelastic:masterfrom
mayya-sharipova:http-logs-add-merge-1-seg

Conversation

@mayya-sharipova
Copy link
Copy Markdown
Contributor

@mayya-sharipova mayya-sharipova commented Nov 13, 2019

Measure the performance of sort operations
after force merging to 1 segment.

PR elastic/elasticsearch#48533 adds a new merge policy that interleaves old and new
segments on force merge. This checks the sort
performance with this policy after docs are merged to
1 segment.

Measure the performance of sort operations
after force merging to 1 segment.

PR #48533 adds a new merge policy that interleaves old and new
segments on force merge. We would like to check the sort
performance with this policy after docs are merged to
1 segment.
Copy link
Copy Markdown
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a comment on the force-merge timeout.

"name": "force-merge-1-seg",
"operation": {
"operation-type": "force-merge",
"max-num-segments": 1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add request-timeoutand set it to a value that is high enough (I guess 7200 (2 hours) should suffice) to ensure we'll wait long enough for this operation to finish? Otherwise we might run queries while the force merge is still ongoing in the background.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmitterdorfer Thanks for the feedback. Addressed in 77faa8b

Copy link
Copy Markdown
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@mayya-sharipova mayya-sharipova merged commit 93c7da7 into elastic:master Nov 14, 2019
@mayya-sharipova mayya-sharipova deleted the http-logs-add-merge-1-seg branch November 14, 2019 15:12
@mayya-sharipova
Copy link
Copy Markdown
Contributor Author

@danielmitterdorfer we would like to see these benchmarks starting from ES 7.6. For this, should I backport this PR to rally-tracks branch 7?

@danielmitterdorfer
Copy link
Copy Markdown
Member

For this, should I backport this PR to rally-tracks branch 7?

@mayya-sharipova yes, that would do the trick. :)

mayya-sharipova added a commit that referenced this pull request Nov 14, 2019
Measure the performance of sort operations
after force merging to 1 segment.

PR elastic/elasticsearch#48533 adds a new merge policy that
interleaves old and new segments on force merge. 
This checks the sort performance with this policy 
after docs are merged to 1 segment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants