Set number of shards explicitly for all tracks#44
Merged
danielmitterdorfer merged 1 commit intoelastic:masterfrom May 14, 2018
Merged
Set number of shards explicitly for all tracks#44danielmitterdorfer merged 1 commit intoelastic:masterfrom
danielmitterdorfer merged 1 commit intoelastic:masterfrom
Conversation
With this commit we set the number of shards explicitly to the default of five shards in order to keep results consistent. Relates elastic/elasticsearch#30539
dliappis
approved these changes
May 14, 2018
Contributor
dliappis
left a comment
There was a problem hiding this comment.
LGTM. We can move the number_of_shards defaults from noaa, nested and nyc_taxis to index.json in a separate PR, as discussed.
Member
Author
|
Thanks for the review! I'll create a separate PR for consistent handling of such index settings in other tracks as well. |
danielmitterdorfer
added a commit
that referenced
this pull request
May 22, 2018
With this commit we set the number of shards explicitly to the default of five shards in order to keep results consistent. Relates elastic/elasticsearch#30539 Relates #44
danielmitterdorfer
added a commit
that referenced
this pull request
May 22, 2018
With this commit we set the number of shards explicitly to the default of five shards in order to keep results consistent. Relates elastic/elasticsearch#30539 Relates #44
danielmitterdorfer
added a commit
that referenced
this pull request
May 22, 2018
With this commit we set the number of shards explicitly to the default of five shards in order to keep results consistent. Relates elastic/elasticsearch#30539 Relates #44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.
Relates elastic/elasticsearch#30539