Merged
Conversation
added 5 commits
December 3, 2021 14:38
dliappis
reviewed
Dec 6, 2021
Contributor
dliappis
left a comment
There was a problem hiding this comment.
Thank you. This is much better and will allow for a separate dashboard.
In general this looks good already and my tests passed.
I left a few small comments.
sql/track.json
Outdated
| "corpora": [ | ||
| { | ||
| "name": "noaa", | ||
| "base-url": "https://rally-tracks.elastic.co/noaa", |
Contributor
There was a problem hiding this comment.
Given that we redefine the mappings in this track, I wonder if we are risking problems, in the unlikely case that the noaa corpora gets updated.
Would it make sense to store the same corpora (it's 9GB uncompressed) in a folder/object of its own (and accept the duplication) but thus ensure they are independent?
Contributor
Author
There was a problem hiding this comment.
good point, I agree that it's probably worth it to duplicate the compressed data (~1GB) to avoid these issues. I've created a copy in /noaa-sql and updated the path accordingly.
Contributor
Author
My plan is to backport to the 7.12 and 7.14 branches since they already include the old SQL challenge. I also verified that all the queries run with 7.12.1. |
Contributor
Ok we are ready to merge then. |
Luegg
pushed a commit
to Luegg/rally-tracks
that referenced
this pull request
Dec 6, 2021
Extracts the SQL challenge into its own track to make it easier to have separate dashboards for the SQL tasks and to reduce coupling between NOAA and SQL benchmarks. This PR also addresses some other issues that have been identified in the meantime: - Force-merges the index into a single segment to reduce variability between runs - Adds the `wait-until-merges-finish` task to ensure merging finished before running the queries - Introduces a `query_percentage` track parameter as a convenience to get faster results when doing experimentations (to be taken with a huge grain of salt of course) - Ensures that `page_timeout` and `request_timeout` are configured correctly such that the track can be run on revisions with or without elastic/elasticsearch#79360. Apart from these changes, the queries themselves have not been touched.
Luegg
pushed a commit
to Luegg/rally-tracks
that referenced
this pull request
Dec 6, 2021
Extracts the SQL challenge into its own track to make it easier to have separate dashboards for the SQL tasks and to reduce coupling between NOAA and SQL benchmarks. This PR also addresses some other issues that have been identified in the meantime: - Force-merges the index into a single segment to reduce variability between runs - Adds the `wait-until-merges-finish` task to ensure merging finished before running the queries - Introduces a `query_percentage` track parameter as a convenience to get faster results when doing experimentations (to be taken with a huge grain of salt of course) - Ensures that `page_timeout` and `request_timeout` are configured correctly such that the track can be run on revisions with or without elastic/elasticsearch#79360. Apart from these changes, the queries themselves have not been touched.
Luegg
pushed a commit
that referenced
this pull request
Dec 6, 2021
Extracts the SQL challenge into its own track to make it easier to have separate dashboards for the SQL tasks and to reduce coupling between NOAA and SQL benchmarks. This PR also addresses some other issues that have been identified in the meantime: - Force-merges the index into a single segment to reduce variability between runs - Adds the `wait-until-merges-finish` task to ensure merging finished before running the queries - Introduces a `query_percentage` track parameter as a convenience to get faster results when doing experimentations (to be taken with a huge grain of salt of course) - Ensures that `page_timeout` and `request_timeout` are configured correctly such that the track can be run on revisions with or without elastic/elasticsearch#79360. Apart from these changes, the queries themselves have not been touched.
Luegg
pushed a commit
that referenced
this pull request
Dec 6, 2021
Extracts the SQL challenge into its own track to make it easier to have separate dashboards for the SQL tasks and to reduce coupling between NOAA and SQL benchmarks. This PR also addresses some other issues that have been identified in the meantime: - Force-merges the index into a single segment to reduce variability between runs - Adds the `wait-until-merges-finish` task to ensure merging finished before running the queries - Introduces a `query_percentage` track parameter as a convenience to get faster results when doing experimentations (to be taken with a huge grain of salt of course) - Ensures that `page_timeout` and `request_timeout` are configured correctly such that the track can be run on revisions with or without elastic/elasticsearch#79360. Apart from these changes, the queries themselves have not been touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the SQL challenge into its own track to make it easier to have separate dashboards for the SQL tasks and to reduce coupling between NOAA and SQL benchmarks.
This PR also addresses some other issues that have been identified in the meantime:
wait-until-merges-finishtask to ensure merging finished before running the queriesquery_percentagetrack parameter as a convenience to get faster results when doing experimentations (to be taken with a huge grain of salt of course)page_timeoutandrequest_timeoutare configured correctly such that the track can be run on revisions with or without SQL: fix use of requestTimeout and pageTimeout query parameters elasticsearch#79360.Apart from these changes, the queries themselves have not been touched.