Add significant_text challenge#176
Merged
danielmitterdorfer merged 3 commits intoelastic:masterfrom May 11, 2021
Merged
Conversation
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
approved these changes
May 6, 2021
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for the PR! One nit but LGTM.
geonames/operations/default.json
Outdated
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Nit: Missing new line at the end of the file.
Member
Author
|
Thanks @danielmitterdorfer ! |
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
danielmitterdorfer
pushed a commit
that referenced
this pull request
May 11, 2021
I've been looking into a performance drop in significant text in 7.9 and needed a rally challenge to test against. This is that!
Member
Author
|
Thanks @danielmitterdorfer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been looking into a performance drop in significant text in 7.9 and
needed a rally challenge to test against. This is that!