Add JSON logging config#14
Merged
danielmitterdorfer merged 2 commits intoelastic:masterfrom Jan 29, 2019
Merged
Conversation
Elasticsearch 7.0.0 will switch to a JSON-based layout for logs by default. With this commit we follow suit. Relates elastic/elasticsearch#36833
Member
Author
|
We will hold back merging this until the respective PR is merged in Elasticsearch. |
dliappis
approved these changes
Jan 23, 2019
Contributor
dliappis
left a comment
There was a problem hiding this comment.
LGTM thanks. Compared this with https://github.com/elastic/elasticsearch/pull/36833/files#diff-ff0409b61613c1d784486fde4ffa6a72 and looks identical.
Member
Author
|
Thanks for the review! I'll test it once more when the changes are in Elasticsearch and will merge it then. |
dliappis
approved these changes
Jan 29, 2019
Contributor
dliappis
left a comment
There was a problem hiding this comment.
LGTM. I diffed this with the log4j2.properties merged in the ES repo and it is identical apart from the iw / imc logging jinja2 conditional sections.
Member
Author
|
Thanks for the quick (re-)review! I'll merge this once elastic/rally#637 is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch 7.0.0 will switch to a JSON-based layout for logs by
default. With this commit we follow suit.
Relates elastic/elasticsearch#36833