Ignore JSON logs for merge parts analysis#637
Merged
danielmitterdorfer merged 1 commit intoelastic:masterfrom Jan 29, 2019
Merged
Ignore JSON logs for merge parts analysis#637danielmitterdorfer merged 1 commit intoelastic:masterfrom
danielmitterdorfer merged 1 commit intoelastic:masterfrom
Conversation
With this commit we ignore any JSON log files when analyzing merge parts. Because Elasticsearch writes both plain text and JSON log files with elastic/elasticsearch#36833, we need to ignore one of them in order to avoid double-counting. We choose to ignore the JSON files for now as this is backwards-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we ignore any JSON log files when analyzing merge
parts. Because Elasticsearch writes both plain text and JSON log files
with elastic/elasticsearch#36833, we need to ignore one of them in order
to avoid double-counting. We choose to ignore the JSON files for now as
this is backwards-compatible.