This repository was archived by the owner on Jan 27, 2023. It is now read-only.
Copy pipeline dirs to ingest_pipeline#108
Merged
ruflin merged 1 commit intoelastic:masterfrom Jul 1, 2020
Merged
Conversation
This is to ensure no directories contain -. In a follow up, the directories with `-` will be removed.
Contributor
|
Hmm, I wonder if symlinks would work instead of actual copies. Then we don't have to worry about old and new contents getting out of sync for the duration that both exist. We can then do the move later when it's safe to remove to older folders. WDYT? |
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Collaborator
Author
|
I don't think symlinks will work as Kibana works with the actual files inside the |
ycombinator
approved these changes
Jul 1, 2020
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
LGTM.
$ find packages -iname ingest-pipeline -type d | sort > /tmp/old
$ find packages -iname ingest_pipeline -type d | sort > /tmp/new
$ cat /tmp/old | tr \- \_ | diff /tmp/new - | wc -l
0
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
Pipelines are input specific. Currently there is no simple way for the integrations manager to know which pipeline should be reference in an input. This introduces the convention that the pipeline name must be a variable which matches one of the pipeline file names in the package. On creating the pipeline instance, the integrations manager will change and prefix the name. The above convention makes it possible to convert it in both places. As an example: The package has an ingest pipeline `foo.yml` or `foo.json`, in the input it will reference `foo`. Then the integration manager builds the datasource and calls it `bar-foo`. It will the replace the input variable with `bar-foo`. This also has consequences on elastic/integrations#3. It means the developer building integrations must ensure that no two pipelines have the same name in one package. To make sure the name in an input matches a pipeline, later on also a validation step should be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to ensure no directories contain -. In a follow up, the directories with
-will be removed.