add hidden field in to data stream manifest#91
Merged
nnamdifrankie merged 3 commits intomasterfrom Dec 7, 2020
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
1 task
mtojek
approved these changes
Dec 7, 2020
Contributor
mtojek
left a comment
There was a problem hiding this comment.
only some nit-picks, but LGTM!
| examples: | ||
| - metrics | ||
| hidden: | ||
| description: Specifies if a datastream is hidden |
rw-access
pushed a commit
to rw-access/package-spec
that referenced
this pull request
Mar 23, 2021
* Update package-spec to latest version * Fix: mage check
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/elastic/security-team/issues/548
This PR adds the the hidden fields to data stream manifest file. The hidden field allows fleet to mark the data stream as hidden elastic/elasticsearch#63987 . This hidden feature is needed for issue 548 to hide the data stream from views.
hiddenfieldFurther, the
hiddenfield will correspond with this ES change: elastic/elasticsearch#63987 . We want to give the flexibility for package authors to denote adata streamas hidden for purposes such as this where adata streamis not intended for app specific usage and should be hidden to reduce user confusion.Our specific use case, again, has to do with a
data streamthat is intended to be queried by a separate telemetry server. As a result, we want thedata streamto be hidden to reduce user confusion.