Validate that custom ilm_policies are defined in the package#413
Merged
jsoriano merged 5 commits intoelastic:mainfrom Sep 14, 2022
Merged
Validate that custom ilm_policies are defined in the package#413jsoriano merged 5 commits intoelastic:mainfrom
jsoriano merged 5 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Member
Author
|
Migration docs added in elastic/elastic-package#977. |
mrodm
previously approved these changes
Sep 13, 2022
Contributor
mrodm
left a comment
There was a problem hiding this comment.
👍 Added some non-blocking comments
mrodm
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data streams can have custom ILM policies since #90, but nothing is checking that these policies actually exist.
This new validation checks that the ILM policy is defined in the same data stream where it is used, what helps to have self-contained packages, and is coherent with the current use of this feature in existing packages.
Fixes #92.