Skip to content

Ensure integrity between input groups and data streams#143

Merged
mtojek merged 4 commits intoelastic:masterfrom
mtojek:132-data-stream-integrity
Mar 3, 2021
Merged

Ensure integrity between input groups and data streams#143
mtojek merged 4 commits intoelastic:masterfrom
mtojek:132-data-stream-integrity

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Mar 2, 2021

What does this PR do?

This PR introduces additional format checker to verify presence of a data stream.

Why is it important?

The format checker will be used to ensure the integrity between input groups and data streams.

Checklist

Related issues

@mtojek mtojek self-assigned this Mar 2, 2021
@mtojek mtojek requested a review from ycombinator March 2, 2021 13:29
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #143 updated

  • Start Time: 2021-03-03T09:33:21.761+0000

  • Duration: 9 min 5 sec

  • Commit: 8fe5d86

Trends 🧪

Image of Build Times

@mtojek mtojek mentioned this pull request Mar 2, 2021
8 tasks
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 5777b5f into elastic:master Mar 3, 2021
rw-access pushed a commit to rw-access/package-spec that referenced this pull request Mar 23, 2021
* Add partially AWS package to test

* Implement field assertion

* Fix: check error.message

* Add partial SNS data stream (wildcard fields)

* Sort imports

* Validate document body

* Enable field validator in system runner

* More fixes for tests

* Multiline multierror

* Use custom multierror

* Fix: pass failure details from system runner

* Fix: return nil

* Still fighting with validation

* Fix: add missing field definitions

* Fix for geo_point

* Basic type verification

* Fix: invalid types

* Skip validation for generic fields

* Add comment to count=1

* Rename to fileInfo

* Rename to scalar

* Fix: typo

* Add continue

* Add comment about regexp

* Notice about skipValidation

* Link

* Rename to findElementDefinition

* Add comment

* Add missing fields

* More fixes

* Aggregate errors

* Fix: properly append errors

* Fix: unit tests

* Fix: unique values

* Test unique multierror

* Add more fields

* More fields

* Fix

* Consider some fields as skipped

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants