import-beats: Set var properties#334
Merged
mtojek merged 15 commits intoelastic:masterfrom Apr 14, 2020
Merged
Conversation
Contributor
Author
|
I'm afraid that there is a bug in the While unpacking in the title: Openmetrics collector metrics
release: beta
type: metrics
streams:
- input: openmetrics/metrics
vars:
- name: hosts
type: text
title: Hosts
multi: true
required: true
show_user: true
default:
- localhost:9090
- name: metrics_filters.exclude
type: text
title: Metrics Filters Exclude
multi: true
required: true
show_user: true
default: []The problem is with I would expect here |
Contributor
Author
|
I submitted an issue: elastic/go-ucfg#159 |
This was referenced Apr 10, 2020
Collaborator
|
Overall the change LGTM, but I would like to have it split up into 2 PR's. One for the go mod updates and the rest if possible so we can separate the two. +1 on getting vendor check as part of mage check. How many places do we have where we have |
Contributor
Author
Ok, but it will take time to split.
Ok, will do.
I can't give you a straightforward answer at the moment, how many items have
I enforced using the forked branch, but I would like to see a quick fix or workaround pushed. |
Contributor
Author
|
PR for processing |
ruflin
approved these changes
Apr 14, 2020
Collaborator
ruflin
left a comment
There was a problem hiding this comment.
LGTM.
It is great to ahve some default title inside. We should make sure in our package checklist somewhere is to check it looks good in the UI.
| } | ||
|
|
||
| func toVariableTitle(name string) string { | ||
| name = strings.ReplaceAll(name, "_", " ") |
Contributor
Author
There was a problem hiding this comment.
We should make sure in our package checklist somewhere is to check it looks good in the UI.
https://github.com/elastic/package-registry/blob/master/CONTRIBUTING.md
Point no 7: Review titles and descriptions in manifest files
ruflin
reviewed
Apr 14, 2020
| @@ -2,9 +2,9 @@ | |||
| github.com/blang/semver | |||
| # github.com/davecgh/go-spew v1.1.0 | |||
| github.com/davecgh/go-spew/spew | |||
| # github.com/elastic/go-ucfg v0.7.0 | |||
| # github.com/elastic/go-ucfg v0.8.3 => github.com/mtojek/go-ucfg v0.8.4-0.20200409161607-b87b280107a8 | |||
Collaborator
There was a problem hiding this comment.
Lets not forget to revert this when your PR gets merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
import-beatsscript:Changes:
[]map[string]interface{}withutil.Variablefor having properties defined in ordergo-ucfg(issue: panic: reflect: call of reflect.Value.Type on zero Value go-ucfg#159)docs/api/package.jsondue to changes inutil.Dataset(failingmage test)Closes: #318