Add support for updating vendor#341
Conversation
ruflin
left a comment
There was a problem hiding this comment.
I expected CI to fail because of the junit part but it seems it doesn't 🤔 So I'm good with getting this in and then see what @andrewkroh thinks and perhaps fix it later :-D
| github.com/elastic/go-ucfg v0.7.0/go.mod h1:iaiY0NBIYeasNgycLyTvhJftQlQEUO2hpF+FX0JKxzo= | ||
| github.com/gorilla/mux v1.7.2 h1:zoNxOV7WjqXptQOVngLmcSQgXmgk4NMz1HibBchjl/I= | ||
| github.com/gorilla/mux v1.7.2/go.mod h1:1lud6UwP+6orDFRuTfBEV8e9/aOM/c4fVVCaMa2zaAs= | ||
| github.com/jstemmer/go-junit-report v0.9.1 h1:6QPYqodiu3GuPL+7mfx+NwDdp2eTkp9IfEUpgAwUN0o= |
There was a problem hiding this comment.
I think we need these for Jenkins. @andrewkroh might know more here?
There was a problem hiding this comment.
I updated the code to add the go-junit-report dependency after go mod tidy.
| func Vendor() error { | ||
| fmt.Println(">> mod - updating vendor directory") | ||
|
|
||
| err := sh.RunV("go", "mod", "tidy") |
There was a problem hiding this comment.
Perhaps we can remove tidy in this PR so it doesn't remove the go-junit part?
There was a problem hiding this comment.
I think I solved this, see above.
|
@mtojek Hm, I perhaps just found a problem with this. Will this create a diff every time a dependency is updated? Meaning a PR could pass CI today but fails tomorrow? This should not be the case. |
The dependency graph can be updated with the Please correct me if I'm wrong. |
ruflin
left a comment
There was a problem hiding this comment.
SGTM. Lets get this in! Thanks for the fix.
This PR extends the
magecommand with support for refreshing thevendordirectory.