Skip to content

Remove docs for managed agent on k8s#799

Merged
dedemorton merged 1 commit intoelastic:masterfrom
ChrsMark:remove_managed_agent_k8s_docs
Jun 24, 2021
Merged

Remove docs for managed agent on k8s#799
dedemorton merged 1 commit intoelastic:masterfrom
ChrsMark:remove_managed_agent_k8s_docs

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

This PR removes section for managed elastic-agent on k8s since we don't currently officially support it.
K8s manifests are also being removed: elastic/beats#26368

@ghost
Copy link
Copy Markdown

ghost commented Jun 18, 2021

A documentation preview will be available soon:

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Jun 18, 2021

I wonder if we should fully remove it or instead mainly remove the links to the manifest files and mention that it is not fully supported yet. But we have already questions on discuss and users will run it on k8s, so some guidance would be good.

@ChrsMark
Copy link
Copy Markdown
Member Author

@ruflin I think that providing guidance without an actual manifest would be incomplete. Also I have not run the case yet so I'm not sure what kind of guidance we could provide here.

We can prioritise the work for elastic/beats#25237 even in a primitive stage so as to have something complete soon. We also need this for ourselves when we test k8s integration/package manually in managed mode.

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Jun 18, 2021

SGTM

@dedemorton
Copy link
Copy Markdown
Contributor

Can we just remove this from the documentation build rather than deleting the file completely?

To do that, you just need to comment out lines 19 and 34

* <<running-on-kubernetes>>
...

include::running-on-kubernetes.asciidoc[leveloffset=+1]

If you think it's better to remove the file completely, then make sure you also remove these lines ^^ to fix the doc build.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the remove_managed_agent_k8s_docs branch from 03630b1 to 245bd37 Compare June 22, 2021 07:04
@ChrsMark
Copy link
Copy Markdown
Member Author

@dedemorton what you proposed sounds better so I applied your approach, thanks!

@ChrsMark
Copy link
Copy Markdown
Member Author

@dedemorton can we have this in soon since the manifests have already been removed?

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry about the delay. I fell down a TLS rabbit hole.

@dedemorton
Copy link
Copy Markdown
Contributor

I'm going to take the liberty of merging and backporting this.

@dedemorton dedemorton merged commit 2c56112 into elastic:master Jun 24, 2021
dedemorton pushed a commit to dedemorton/observability-docs that referenced this pull request Jun 24, 2021
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
dedemorton pushed a commit to dedemorton/observability-docs that referenced this pull request Jun 24, 2021
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
dedemorton added a commit that referenced this pull request Jun 24, 2021
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
dedemorton added a commit that referenced this pull request Jun 24, 2021
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants