Skip to content

Change agent pprof default to false#1289

Merged
michel-laterman merged 2 commits intoelastic:mainfrom
michel-laterman:agent-pprof-default
Nov 30, 2021
Merged

Change agent pprof default to false#1289
michel-laterman merged 2 commits intoelastic:mainfrom
michel-laterman:agent-pprof-default

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

As discussed in elastic/beats#29108 we will be changing the default agent.monitoring.pprof option to false.

Behaviour of the option has also slightly changed to also apply to beats that the agent runs: elastic/beats#29155

@michel-laterman michel-laterman added docs Improvements or additions to documentation Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Nov 25, 2021
@michel-laterman michel-laterman requested a review from a team as a code owner November 25, 2021 18:13
@ghost
Copy link
Copy Markdown

ghost commented Nov 25, 2021

A documentation preview will be available soon:

@michel-laterman
Copy link
Copy Markdown
Contributor Author

I'll need to backport to 8.0 and 7.16

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor fixes. Otherwise looks good. Thanks for updating the docs!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending a clean build)

@michel-laterman michel-laterman merged commit 918792b into elastic:main Nov 30, 2021
michel-laterman added a commit to michel-laterman/observability-docs that referenced this pull request Nov 30, 2021
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
michel-laterman added a commit to michel-laterman/observability-docs that referenced this pull request Nov 30, 2021
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
michel-laterman added a commit that referenced this pull request Nov 30, 2021
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
michel-laterman added a commit that referenced this pull request Nov 30, 2021
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@michel-laterman michel-laterman deleted the agent-pprof-default branch April 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants