Skip to content

Introduce memory usage estimation mode in data_frame_analyzer#584

Merged
przemekwitek merged 6 commits intoelastic:masterfrom
przemekwitek:model_memory_limit
Aug 7, 2019
Merged

Introduce memory usage estimation mode in data_frame_analyzer#584
przemekwitek merged 6 commits intoelastic:masterfrom
przemekwitek:model_memory_limit

Conversation

@przemekwitek
Copy link
Copy Markdown

@przemekwitek przemekwitek commented Aug 2, 2019 •
edited
Loading

Introduce a mode in which data_frame_analyzer binary only outputs memory usage estimations but does not perform any analysis. This mode will be used by the new endpoint in Java server.

Relates elastic/elasticsearch#44699

@przemekwitek przemekwitek force-pushed the model_memory_limit branch 4 times, most recently from 1a97d9c to 978a6b4 Compare August 6, 2019 10:23
tveasey
tveasey reviewed Aug 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick pass through. Looking pretty good. I know you're working on tests. I've made a couple of suggestions which might have some knock on effects for testing, so thought I'd just go ahead and submit these.

Introduce a mode in which data_frame_analyzer binary only outputs mem…
462023d 
…ory estimations but does not perform any analysis
@przemekwitek
Copy link
Copy Markdown
Author

przemekwitek commented Aug 6, 2019

I did a quick pass through. Looking pretty good. I know you're working on tests. I've made a couple of suggestions which might have some knock on effects for testing, so thought I'd just go ahead and submit these.

Thanks. I've just sent this PR to regular review and will address your comments shortly.

@przemekwitek przemekwitek marked this pull request as ready for review August 6, 2019 11:08
tveasey
tveasey approved these changes Aug 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! This looks good to go. Just a couple of comment typos and a suggestion. Also, I propose we use the usual error handling mechanism for dealing with the case that the runner is null. I'm going to go ahead and approve because I don't think this needs any further reviews.

droberts195
droberts195 reviewed Aug 7, 2019
View reviewed changes
droberts195
droberts195 approved these changes Aug 7, 2019
View reviewed changes
Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 2d8b24b into elastic:master Aug 7, 2019
@przemekwitek przemekwitek deleted the model_memory_limit branch August 7, 2019 15:15
przemekwitek pushed a commit to przemekwitek/ml-cpp that referenced this pull request Aug 7, 2019
Introduce memory usage estimation mode in data_frame_analyzer (elasti…
16f6aff 
…c#584)
@przemekwitek przemekwitek mentioned this pull request Aug 7, 2019
Merged
przemekwitek pushed a commit that referenced this pull request Aug 7, 2019
Introduce memory usage estimation mode in data_frame_analyzer (#584) (#…
56a87fb 
…588)
@droberts195 droberts195 mentioned this pull request Aug 9, 2019
Closed
6 tasks
@przemekwitek przemekwitek mentioned this pull request Nov 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tveasey tveasey tveasey approved these changes

+1 more reviewer

@droberts195 droberts195 droberts195 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml/DataFrameAnalysis >non-issue v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@przemekwitek @droberts195 @tveasey