[ML] Standardise start of test debug#58
Merged
tveasey merged 2 commits intoelastic:masterfrom Apr 17, 2018
tveasey:refactor/standardise-start-test-debug
Merged
[ML] Standardise start of test debug#58tveasey merged 2 commits intoelastic:masterfrom tveasey:refactor/standardise-start-test-debug
tveasey merged 2 commits intoelastic:masterfrom
tveasey:refactor/standardise-start-test-debug
Conversation
|
This seems like a very low risk change - I don't see why it cannot be backported to 6.3.0 for consistency. Feature freeze isn't until Friday so it can be cherry-picked to the 6.x branch on Thursday or Friday. Or am I missing something? |
Contributor
Author
|
I thought it was non-essential, which is why I didn't target, but I agree zero risk so let's port back. |
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
Performs start of test debug logging from CTestTimer::startTest
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
Performs start of test debug logging from CTestTimer::startTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can and should be doing start of test debug logging from
CTestTimer::startTestwhich is supplied the test name by the CppUnit test framework.