[ML] Introduction disk usage parameter for data frames#522
Merged
valeriy42 merged 5 commits intoelastic:masterfrom Jul 1, 2019
Merged
[ML] Introduction disk usage parameter for data frames#522valeriy42 merged 5 commits intoelastic:masterfrom
valeriy42 merged 5 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
retest |
Contributor
Author
|
recheck |
dimitris-athanasiou
approved these changes
Jun 28, 2019
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM apart from a small typo in a comment
lib/api/CDataFrameAnalysisRunner.cc
Outdated
| if (memoryUsage <= memoryLimit) { | ||
| break; | ||
| } | ||
| // if we are not allowed to spill over to disk than only one partition is possible |
Contributor
There was a problem hiding this comment.
nit: typo than -> then?
Contributor
Author
|
retest |
2 similar comments
Contributor
Author
|
retest |
|
retest |
|
On this one the Windows failure is not due to the CI infra: We’ve used |
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Jul 1, 2019
This PR introduces an optional json specification parameter disk_usage_allowed, which is false by default. This parameter controls whether or not the system can overflow data frame to disk. Relates elastic/ml-team#168
valeriy42
added a commit
that referenced
this pull request
Jul 1, 2019
This PR introduces an optional json specification parameter disk_usage_allowed, which is false by default. This parameter controls whether or not the system can overflow data frame to disk. Relates elastic/ml-team#168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional json specification parameter
disk_usage_allowed, which isfalseby default. This parameter controls whether or not the system can overflow data frame to disk.Relates elastic/ml-team#168