Skip to content

[ML] Build PyTorch without Breakpad#2255

Merged
droberts195 merged 1 commit intoelastic:mainfrom
droberts195:no_breakpad_for_pytorch
Apr 11, 2022
Merged

[ML] Build PyTorch without Breakpad#2255
droberts195 merged 1 commit intoelastic:mainfrom
droberts195:no_breakpad_for_pytorch

Conversation

@droberts195
Copy link
Copy Markdown

@droberts195 droberts195 commented Apr 11, 2022

Breakpad causes the libtorch_cpu.so library to have an
executable stack, which is undesirable.

Fixes elastic/elasticsearch#85691

@droberts195
[ML] Build PyTorch without Breakpad
5dcc9fb 
Breakpad causes the libtorch_cpu.so library to have an
executable stack, which is undesirable.

Fixes elastic/elasticsearch#85691
@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Apr 11, 2022

>non-issue because logically this is part of #2238 and will be delivered in the same release.

davidkyle
davidkyle approved these changes Apr 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Copy Markdown
Author

droberts195 commented Apr 11, 2022

Confirmed it fixes the problem:

$ docker run -it --rm docker.elastic.co/ml-dev/ml-linux-build:22 /bin/bash
[root@7a31ffe519bf /]# readelf -a /usr/local/gcc103/lib/libtorch_cpu.so | grep -C 2 GNU_STACK
  GNU_EH_FRAME   0x0000000006fe06e4 0x0000000006fe06e4 0x0000000006fe06e4
                 0x0000000000183604 0x0000000000183604  R      4
  GNU_STACK      0x0000000000000000 0x0000000000000000 0x0000000000000000
                 0x0000000000000000 0x0000000000000000  RW     10
  GNU_RELRO      0x0000000007da18c0 0x0000000007da28c0 0x0000000007da28c0
[root@7a31ffe519bf /]# exit
exit
$ docker run -it --rm docker.elastic.co/ml-dev/ml-linux-build:21 /bin/bash
[root@cc63ada4cca2 /]# readelf -a /usr/local/gcc103/lib/libtorch_cpu.so | grep -C 2 GNU_STACK
  GNU_EH_FRAME   0x0000000006ff9e04 0x0000000006ff9e04 0x0000000006ff9e04
                 0x0000000000183bcc 0x0000000000183bcc  R      4
  GNU_STACK      0x0000000000000000 0x0000000000000000 0x0000000000000000
                 0x0000000000000000 0x0000000000000000  RWE    10
  GNU_RELRO      0x0000000007dbd400 0x0000000007dbe400 0x0000000007dbe400
[root@cc63ada4cca2 /]# exit
exit

The difference is that image version 22 added for this PR has RW for its GNU_STACK attributes whereas the old image, version 21, has RWE.

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Apr 11, 2022
@droberts195
Unmute Lintian packaging test
65f4a13 
The test was muted due to elastic#85691.

The underlying problem should be fixed by
elastic/ml-cpp#2255.

This PR needs to be merged after the new artifacts
created from merging elastic/ml-cpp#2255 have been
uploaded to S3.
@droberts195 droberts195 mentioned this pull request Apr 11, 2022
Merged
@droberts195 droberts195 merged commit 3eb4114 into elastic:main Apr 11, 2022
@droberts195 droberts195 deleted the no_breakpad_for_pytorch branch April 11, 2022 12:27
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Apr 12, 2022
@droberts195
Unmute Lintian packaging test (#85778)
1a92589 
The test was muted due to #85691.

The underlying problem should be fixed by
elastic/ml-cpp#2255.

This PR needs to be merged after the new artifacts
created from merging elastic/ml-cpp#2255 have been
uploaded to S3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees

No one assigned

Labels

3rd party models :ml >non-issue v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] DebMetadataTests test05CheckLintian failing

2 participants

@droberts195 @davidkyle