[ML] Fix bug upgrading state from 5.6 direct to 6.3 causing SIGSEGV on open job#143
Merged
tveasey merged 3 commits intoelastic:masterfrom Jul 4, 2018
Merged
Conversation
droberts195
approved these changes
Jul 4, 2018
droberts195
left a comment
There was a problem hiding this comment.
LGTM
I just left one suggestion about where an extra comment might help future readers.
| core::CPersistUtils::fromString(traverser.value(), lastUpdates)) | ||
| } while (traverser.next()); | ||
|
|
||
| if (lastUpdates.empty()) { |
There was a problem hiding this comment.
Could add a comment to say this is needed because lastUpdates wasn't present in 5.6.
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Jul 4, 2018
…n open job (elastic#143) Closes elastic#141.
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Jul 4, 2018
…n open job (elastic#143) Closes elastic#141.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also corrects upgrading the trend component model. The current behaviour could result in large prediction errors immediately after upgrading.
Closes #141.