CLEANUP+JAVAFICATION+PERFORMANCE: Keep hard reference to Ruby ThreadContext, simplify code accordingly#9401
Closed
original-brownbear wants to merge 1 commit intoelastic:masterfrom
Conversation
…Context, simplify code accordingly
ea08393 to
c1a5486
Compare
Contributor
Author
|
@danhermann thanks! |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 18, 2018
…Context, simplify code accordingly Fixes #9401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized we can keep Ruby's thread context strongly referenced in workers since those threads are always hot and have a clearly defined lifecycle.
PS: I know that some of the remaining syntax generation code may be a little redundant now as well. Will keep cleaning this up further in subsequent PRs. This one is large enough already IMO :)