[test] ls2ls spec adds heartbeat to keep alive#17228
Merged
kaisecheng merged 3 commits intoelastic:mainfrom Mar 5, 2025
Merged
[test] ls2ls spec adds heartbeat to keep alive#17228kaisecheng merged 3 commits intoelastic:mainfrom
kaisecheng merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
|
Contributor
|
|
andsel
approved these changes
Mar 5, 2025
Member
andsel
left a comment
There was a problem hiding this comment.
LGTM, but please add a comment on the input why it's needed
| generator { | ||
| count => '<%=options[:generator_count]%>' | ||
| } | ||
| heartbeat { |
Member
There was a problem hiding this comment.
Please add a comment that specify the reason why it's needed
kaisecheng
commented
Mar 5, 2025
kaisecheng
commented
Mar 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
|
💔 Build Failed
Failed CI Steps
History
|
This was referenced Mar 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: Mashhurs yaauie#5
Adds heartbeat-input to the LS to LS integration test config to keep upstream Logstash alive.