Skip to content

Backport PR #171226 to 8.x: Fix acceptance test assertions for updated plugin remove#17131

Merged
donoghuc merged 1 commit intoelastic:8.xfrom
yaauie:backport_17122_8.x
Feb 20, 2025
Merged

Backport PR #171226 to 8.x: Fix acceptance test assertions for updated plugin remove#17131
donoghuc merged 1 commit intoelastic:8.xfrom
yaauie:backport_17122_8.x

Conversation

@yaauie
Copy link
Copy Markdown
Member

@yaauie yaauie commented Feb 20, 2025 •
edited by donoghuc
Loading

Backport PR #17126 to 8.x branch, original message:

Release notes

[rn:skip]

What does this PR do?

This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.

Why is it important/What is the impact to the user?

No user impact, this is fixing acceptance test assertions

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Logs

Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1361#01952103-6591-43cf-a364-cc876ac8bc21

Failures:
--
  |  
  | 1) CLI operation behaves like logstash remove logstash-plugin remove on [Ubuntu 20.04] when the plugin isn't installed fails to remove it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash remove" called from ./acceptance/spec/lib/cli_operation_spec.rb:38
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/remove.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | Finished in 20 minutes 37 seconds (files took 1.57 seconds to load)
  | 30 examples, 1 failure, 1 pending

@donoghuc @yaauie
Fix acceptance test assertions for updated plugin remove (elastic#17126)
429095d 
This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Feb 20, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@donoghuc
Copy link
Copy Markdown
Member

donoghuc commented Feb 20, 2025

I think the details on this PR description are wrong, This appears to be the backport of #17126 (not #17122). I should have named the PR titles uniquely, sorry 😬. I will go ahead and edit the description and get this merged.

We will need a backport of #17122 also.

Looks like exhaustive tests are only on a timer trigger for 8.x so we have not seen failures yet.

@donoghuc donoghuc changed the title Backport PR #17122 to 8.x: Fix acceptance test assertions for updated plugin remove Backport PR #171226 to 8.x: Fix acceptance test assertions for updated plugin remove Feb 20, 2025
@donoghuc
Copy link
Copy Markdown
Member

donoghuc commented Feb 20, 2025

Backport for #17122 #17132

donoghuc
donoghuc approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict was on line 35 where in main a different method for running sudo command is used. This is the correct merge conflict resolution as we do not change line 35.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 20, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

@donoghuc donoghuc merged commit 5109867 into elastic:8.x Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donoghuc donoghuc donoghuc approved these changes

Assignees

No one assigned

Labels

backport v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaauie @donoghuc @elasticmachine